Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Update rocketchat:streamer to be compatible with previous version #9094

Merged
merged 1 commit into from
Dec 13, 2017
Merged

[FIX] Update rocketchat:streamer to be compatible with previous version #9094

merged 1 commit into from
Dec 13, 2017

Conversation

sampaiodiego
Copy link
Member

@RocketChat/core

Make it backwards compatible so it fixes this exception:

TypeError: undefined is not iterable
  at Streamer.isReadAllowed (/app/bundle/programs/server/packages/rocketchat_streamer.js:258:37)
  at Subscription.<anonymous> (/app/bundle/programs/server/packages/rocketchat_streamer.js:356:15)
  at Subscription.<anonymous> (/app/bundle/programs/server/packages/rocketchat_lib.js:2149:15)
  at packages/matb33_collection-hooks.js:307:21
  at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1186:15)
  at Subscription._handler (packages/matb33_collection-hooks.js:306:28)
  at maybeAuditArgumentChecks (/app/bundle/programs/server/packages/ddp-server.js:1826:12)
  at DDP._CurrentPublicationInvocation.withValue (/app/bundle/programs/server/packages/ddp-server.js:1166:73)
  at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1186:15)
  at Subscription._runHandler (/app/bundle/programs/server/packages/ddp-server.js:1166:51)
  at Session._startSubscription (/app/bundle/programs/server/packages/ddp-server.js:1014:9)
  at Session.sub (/app/bundle/programs/server/packages/ddp-server.js:806:12)
  at /app/bundle/programs/server/packages/ddp-server.js:744:85

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9094 December 12, 2017 19:26 Inactive
@sampaiodiego sampaiodiego added this to the 0.60.0 milestone Dec 13, 2017
@sampaiodiego sampaiodiego merged commit 4b14dd8 into develop Dec 13, 2017
@sampaiodiego sampaiodiego deleted the update-stream-package branch December 13, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
type: release candidate bug
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sampaiodiego @geekgonecrazy @engelgabriel